Changeset 123

Timestamp:

03/25/06 16:21:54 (3 years ago)

Author:

xi

Message:

Fix a leak in _syckmodule.c (thanks, jbj)

Change the production status to Stable.

Files:

• pysyck/trunk/ext/_syckmodule.c (modified) (2 diffs)
• pysyck/trunk/setup.py (modified) (1 diff)
• pysyck/trunk/tests/test_parser.py (modified) (3 diffs)

pysyck/trunk/ext/_syckmodule.c

@@ -1102 +1102 @@
-        goto error;
-
+    Py_DECREF(object);
+
-    index = PyList_GET_SIZE(self->symbols);
-    PyGILState_Release(gs);
@@ -1321 +1323 @@
-
-    value = PyList_GetItem(self->symbols, index);
+    Py_XINCREF(value);
-
-    Py_DECREF(self->symbols);

pysyck/trunk/setup.py

@@ -15 +15 @@
-DOWNLOAD_URL = "http://pyyaml.org/download/pysyck/%s-%s.tar.gz" % (NAME, VERSION)
-CLASSIFIERS = [
-3 - Alpha
+5 - Production/Stable
-    "Intended Audience :: Developers",
-    "License :: OSI Approved :: BSD License",

pysyck/trunk/tests/test_parser.py

@@ -4 +4 @@
-import _syck
-
-
+, sys
-
-EXAMPLE = """
@@ -174 +174 @@
-"""
-
+LEAKS = """
+- mere scalar
+- [ sequence, may, leak, too]
+- {"it's": mapping, with: many, potential: leaks}
+- {sequence: [], mapping: {}}
+"""
+
-class TestAttributes(unittest.TestCase):
-
@@ -372 +379 @@
-        self.assert_(node.value[0] is node.value[1])
-
+class TestLeaks(unittest.TestCase):
+
+    def testLeaks(self):
+        parser = _syck.Parser(LEAKS)
+        node = parser.parse()
+        dummy = []
+        self.checkLeaks(node, dummy)
+
+    def checkLeaks(self, node, dummy):
+        self.assertEqual(sys.getrefcount(node), sys.getrefcount(dummy))
+        self.assertEqual(sys.getrefcount(node.value), 2)
+        dummy = []
+        container = [dummy]
+        if isinstance(node, _syck.Seq):
+            for item in node.value:
+                self.checkLeaks(item, dummy)
+        elif isinstance(node, _syck.Map):
+            for key in node.value:
+                self.checkLeaks(key, dummy)
+                value = node.value[key]
+                self.checkLeaks(value, dummy)
+