Modify

Ticket #32 (closed defect: fixed)

Opened 8 years ago

Last modified 7 years ago

patch to make libyaml compile in visual studio

Reported by: roel _ dot _ vanhout _ at _ gmail _ dot _ com Owned by: xi
Priority: normal Component: libyaml
Severity: normal Keywords:
Cc:

Description

2 issues:

  • pointer arithmetic on void*'s is a gcc-ism. I 'solved' it by casting them all to a unsigned char (typedef'd), I'm not sure if a unsigned char is guaranteed to be the same size as a void* on all architectures - it worked on 32-bit Windows, FWIW.
  • A shorthand struct assignment didn't work, I'm not sure if it's valid C or not but whatever, by writing it out in full it compiled ok.

Attachments

libyaml_visual_cpp.patch Download (3.2 KB) - added by anonymous 8 years ago.

Change History

Changed 8 years ago by anonymous

comment:1 Changed 7 years ago by xi

  • Status changed from new to closed
  • Resolution set to fixed

Thanks for the patch. Applied in [239].

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.